Better exception management for Azure ServiceBus #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
commented
Dec 9, 2025
andreasohlund
commented
Dec 9, 2025
Member
Author
|
@mauroservienti made some more tweaks to the output, can you take a final look? |
mauroservienti
approved these changes
Dec 10, 2025
Member
mauroservienti
left a comment
mauroservienti
left a comment
There was a problem hiding this comment.
Minor tweak; otherwise, looks good
|
|
||
| if (metricQueryResult is null) | ||
| { | ||
| throw new Exception("No metrics query results returned for Microsoft.ServiceBus/Namespace"); |
Member
There was a problem hiding this comment.
Suggested change
| throw new Exception("No metrics query results returned for Microsoft.ServiceBus/Namespace"); | |
| throw new Exception($"No metrics query results returned for {MicrosoftServicebusNamespacesMetricsNamespace}"); |
Member
Author
There was a problem hiding this comment.
oops, I had it to automerge, will apply it to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the code more picky about the results from the metrics API and also throws if the API call indicates an error